|
|
DescriptionPlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated
Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to
fix download request limiter test for renderer-initiated case in
PlzNavigate.
R=clamy@chromium.org, dominickn@chromium.org
BUG=510836
Committed: https://crrev.com/045680dc6a3ef6a2b55e834443aa171b85a9f534
Cr-Commit-Position: refs/heads/master@{#417373}
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : rebase #
Messages
Total messages: 34 (26 generated)
Description was changed from ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated R=clamy@chromium.org BUG=510836 ========== to ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org BUG=510836 ==========
Description was changed from ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org BUG=510836 ========== to ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org BUG=510836 ==========
scottmg@chromium.org changed reviewers: + dominickn@chromium.org
Description was changed from ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org BUG=510836 ========== to ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 ==========
clamy: overall review and content OWNERS dominickn: chrome/browser/download/download_request_limiter_unittest.cc
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/07 18:00:09, scottmg wrote: > clamy: overall review and content OWNERS > dominickn: chrome/browser/download/download_request_limiter_unittest.cc chrome/browser/download/download_request_limiter_unittest.cc lgtm. Thanks for helping make this a lot cleaner!
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:60001) has been deleted
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Thanks! Lgtm.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dominickn@chromium.org Link to the patchset: https://codereview.chromium.org/2319733002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 ========== to ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 ========== to ========== PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 Committed: https://crrev.com/045680dc6a3ef6a2b55e834443aa171b85a9f534 Cr-Commit-Position: refs/heads/master@{#417373} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/045680dc6a3ef6a2b55e834443aa171b85a9f534 Cr-Commit-Position: refs/heads/master@{#417373} |