Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 2319733002: PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
dominickn, clamy
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Fix DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 Committed: https://crrev.com/045680dc6a3ef6a2b55e834443aa171b85a9f534 Cr-Commit-Position: refs/heads/master@{#417373}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -46 lines) Patch
M chrome/browser/download/download_request_limiter_unittest.cc View 1 2 3 6 chunks +16 lines, -24 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M content/test/test_render_frame_host.cc View 1 2 2 chunks +16 lines, -16 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.unit_tests.filter View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 34 (26 generated)
scottmg
clamy: overall review and content OWNERS dominickn: chrome/browser/download/download_request_limiter_unittest.cc
4 years, 3 months ago (2016-09-07 18:00:09 UTC) #5
dominickn
On 2016/09/07 18:00:09, scottmg wrote: > clamy: overall review and content OWNERS > dominickn: chrome/browser/download/download_request_limiter_unittest.cc ...
4 years, 3 months ago (2016-09-08 01:42:33 UTC) #14
clamy
Thanks! Lgtm.
4 years, 3 months ago (2016-09-08 13:13:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319733002/80001
4 years, 3 months ago (2016-09-08 14:38:57 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/289656)
4 years, 3 months ago (2016-09-08 16:59:53 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319733002/80001
4 years, 3 months ago (2016-09-08 17:30:19 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-09-08 19:56:35 UTC) #32
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:59:06 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/045680dc6a3ef6a2b55e834443aa171b85a9f534
Cr-Commit-Position: refs/heads/master@{#417373}

Powered by Google App Engine
This is Rietveld 408576698