Issue 231973004: Reland r20652 "Handlify and convert string.length to new API-style accessor."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231973004: Reland r20652 "Handlify and convert string.length to new API-style accessor." (Closed)

Created:
6 years, 8 months ago by ulan

Modified:
6 years, 8 months ago

Reviewers:
dcarney, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland r20652 "Handlify and convert string.length to new API-style accessor." BUG= R=dcarney@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20767

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -27 lines)			Patch
M	src/accessors.h	View		4 chunks	+22 lines, -2 lines	0 comments	Download
M	src/accessors.cc	View	1 2 3	2 chunks	+54 lines, -14 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	1 2 3	3 chunks	+5 lines, -8 lines	0 comments	Download
M	src/serialize.cc	View		1 chunk	+12 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

ulan

PTAL. The fix is in diff between PS2 and PS1. GetPropertyWithCallback had invalid cast to ...

6 years, 8 months ago (2014-04-10 13:56:24 UTC) #1

Yang

On 2014/04/11 06:18:00, dcarney wrote: > lgtm is this still relevant? lgtm if you were ...

6 years, 8 months ago (2014-04-15 12:11:18 UTC) #3

ulan

On 2014/04/15 12:11:18, Yang wrote: > On 2014/04/11 06:18:00, dcarney wrote: > > lgtm > ...

6 years, 8 months ago (2014-04-15 12:12:07 UTC) #4

ulan

6 years, 8 months ago (2014-04-15 13:25:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r20767 (presubmit successful).