Issue 231973003: Adding network interface type param to net::NetworkInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231973003: Adding network interface type param to net::NetworkInterface (Closed)

Created:
6 years, 8 months ago by Mallinath (Gone from Chromium)

Modified:
6 years, 8 months ago

Reviewers:
agl

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Defined a enum for network interface types and added a field to net::NetworkInterface. This CL doesn't attempt to find network interface type, all are initialized to UNKNOWN type. Subsequence CL's will have platform specific code which will gather network interface type information. BUG= R=agl@chromium.org TBR=gene@chromium.org, justinlin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262851

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -10 lines)			Patch
M	chrome/browser/extensions/api/dial/dial_service_unittest.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_traffic_detector.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/net_util.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	net/base/net_util.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	net/base/net_util_posix.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	net/base/net_util_win.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Mallinath (Gone from Chromium)

@justinlin for api @gene for local_discovery

6 years, 8 months ago (2014-04-09 23:18:49 UTC) #3

Mallinath (Gone from Chromium)

6 years, 8 months ago (2014-04-09 23:20:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r262851 (presubmit successful).