Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2319683002: [heap] Fixes for heap testing (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fixes for heap testing BUG=chromium:636331 R=ulan@chromium.org Committed: https://crrev.com/fdab63f56e45ff25e3c9705631fa188c90a11dcf Cr-Commit-Position: refs/heads/master@{#39273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 5 chunks +15 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Lippautz
ptal fuzzing my way through fragile tests...
4 years, 3 months ago (2016-09-07 16:18:52 UTC) #5
ulan
lgtm
4 years, 3 months ago (2016-09-08 11:18:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319683002/20001
4 years, 3 months ago (2016-09-08 11:18:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 11:20:48 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:21:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdab63f56e45ff25e3c9705631fa188c90a11dcf
Cr-Commit-Position: refs/heads/master@{#39273}

Powered by Google App Engine
This is Rietveld 408576698