Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2319653002: SkPDF: remove unused fallback clipping code (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: remove unused fallback clipping code This code is untested and unnecessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319653002 Committed: https://skia.googlesource.com/skia/+/5edf2908a305d3365a1574a8358343bb26468b35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -105 lines) Patch
M src/pdf/SkPDFDevice.cpp View 2 chunks +10 lines, -105 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319653002/1
4 years, 3 months ago (2016-09-07 15:25:34 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-07 15:25:35 UTC) #4
hal.canary
PTAL
4 years, 3 months ago (2016-09-07 15:25:45 UTC) #6
caryclark
lgtm
4 years, 3 months ago (2016-09-07 16:00:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319653002/1
4 years, 3 months ago (2016-09-07 16:04:31 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:05:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5edf2908a305d3365a1574a8358343bb26468b35

Powered by Google App Engine
This is Rietveld 408576698