Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2319643002: Revert of Add instrumentation to help tracking issue 638400. (Closed)

Created:
4 years, 3 months ago by lfg
Modified:
4 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add instrumentation to help tracking issue 638400. (patchset #2 id:20001 of https://codereview.chromium.org/2307463007/ ) Reason for revert: We collected enough information, reverting. Original issue's description: > Add instrumentation to help tracking issue 638400. > > This CL forces a dump without crash when a RenderFrameImpl is destroyed after creating a pepper plugin, but before initializing it, testing the theory that the RenderFrameImpl may be destroyed during plugin initialization. > > BUG=638400 > > Committed: https://crrev.com/246881fe95d4a2cdf4fcd0dab7c1b987e0f4d8f3 > Cr-Commit-Position: refs/heads/master@{#416353} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638400 Committed: https://crrev.com/fb1228ce0a224b76f2131d9f2a81f332f2b41293 Cr-Commit-Position: refs/heads/master@{#416948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 6 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lfg
Created Revert of Add instrumentation to help tracking issue 638400.
4 years, 3 months ago (2016-09-07 15:18:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319643002/1
4 years, 3 months ago (2016-09-07 15:18:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:10:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb1228ce0a224b76f2131d9f2a81f332f2b41293 Cr-Commit-Position: refs/heads/master@{#416948}
4 years, 3 months ago (2016-09-07 16:13:32 UTC) #6
Charlie Reis
4 years, 3 months ago (2016-09-07 16:27:56 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698