Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231963002: Revert 262050 "Implement a source for remote video tracks." (Closed)

Created:
6 years, 8 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 8 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 262050 "Implement a source for remote video tracks." > Implement a source for remote video tracks. > MediaStreamRemoteVideoSource implements the MediaStreamVideoSource interface > for video tracks received on a PeerConnection. The purpose of the class is > to make sure there is no difference between a video track where the source is > a local source and a video track where the source is a remote video track. > > BUG=334243 > > Review URL: https://codereview.chromium.org/201583003 This caused remote video to appear unexpectedly zoomed and cropped. BUG=334243, 361770 TBR=perkj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -567 lines) Patch
M trunk/src/content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/renderer/media/media_stream_center.cc View 1 chunk +6 lines, -1 line 0 comments Download
M trunk/src/content/renderer/media/media_stream_dependency_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/media_stream_dependency_factory.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_video_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_video_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_video_track.h View 2 chunks +21 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_video_track.cc View 3 chunks +48 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/media/mock_media_stream_dependency_factory.h View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/media/mock_media_stream_dependency_factory.cc View 3 chunks +19 lines, -24 lines 0 comments Download
M trunk/src/content/renderer/media/remote_media_stream_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/media/remote_media_stream_impl.cc View 8 chunks +59 lines, -104 lines 0 comments Download
M trunk/src/content/renderer/media/rtc_peer_connection_handler_unittest.cc View 3 chunks +12 lines, -26 lines 0 comments Download
D trunk/src/content/renderer/media/webrtc/media_stream_remote_video_source.h View 1 chunk +0 lines, -74 lines 0 comments Download
D trunk/src/content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D trunk/src/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
A + trunk/src/content/renderer/media/webrtc/webrtc_video_sink_adapter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/renderer/media/webrtc/webrtc_video_sink_adapter.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 8 months ago (2014-04-09 21:16:13 UTC) #1
vrk (LEFT CHROMIUM)
6 years, 8 months ago (2014-04-09 21:16:53 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r262819.

Powered by Google App Engine
This is Rietveld 408576698