Add UMA for selection drag autoscroll.

Add UMA for selection drag autoscroll.

BUG=644741
Committed: https://crrev.com/e7bad168e3e78aa062b663adea7988552a7978d6
Cr-Commit-Position: refs/heads/master@{#417689}

[sunyunjia, 2016-09-08 15:58:10]

Patchset #1 (id:1) has been deleted

[sunyunjia, 2016-09-08 16:08:46]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 16:09:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-08 16:11:23]

Description was changed from

==========
Add UMA for selection drag autoscroll.

BUG=644741
==========

to

==========
Add UMA for selection drag autoscroll.

BUG=644741
==========

[sunyunjia, 2016-09-08 16:11:23]

sunyunjia@chromium.org changed reviewers:
+ jochen@chromium.org, tdresser@chromium.org

[sunyunjia, 2016-09-08 16:13:11]

PTAL. Thanks!

[sunyunjia, 2016-09-08 16:13:21]

Patchset #1 (id:20001) has been deleted

[tdresser, 2016-09-08 18:23:38]

LGTM

https://codereview.chromium.org/2319623004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/events/dragAndDropScroll-use-count.html
(right):

https://codereview.chromium.org/2319623004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/dragAndDropScroll-use-count.html:19:
var leftButton = 0;
This appears unused.

https://codereview.chromium.org/2319623004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/dragAndDropScroll-use-count.html:22:
var selStartX = scrollable.offsetLeft + 5;
I'd just go with selectionStartX etc.

https://codereview.chromium.org/2319623004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/dragAndDropScroll-use-count.html:26:
var dragStartX = selStartX;
I'd move the drag co-ordinates after the first mouse up, as then it's clear that
they aren't used in the first set of mouse* calls.

[commit-bot: I haz the power, 2016-09-08 18:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:49:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunyunjia, 2016-09-08 23:56:50]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:57:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:02:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunyunjia, 2016-09-09 00:06:50]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 00:07:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:12:02]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sunyunjia, 2016-09-09 02:33:56]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 02:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 02:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:38:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sunyunjia, 2016-09-09 12:24:24]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 12:24:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 12:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 12:27:36]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2016-09-09 13:19:25]

lgtm

https://codereview.chromium.org/2319623004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/drag-and-drop-autoscroll-use-count.html
(right):

https://codereview.chromium.org/2319623004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/drag-and-drop-autoscroll-use-count.html:1:
<style type="text/css">
<!DOCTYPE html>

[sunyunjia, 2016-09-09 13:54:23]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 13:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:10:42]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-09 18:11:46]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-09-09 18:11:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2319623004/#ps80001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into uma-seldrag")

[commit-bot: I haz the power, 2016-09-09 18:12:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:19:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sunyunjia, 2016-09-09 18:28:19]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-09-09 18:28:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2319623004/#ps100001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into uma-seldrag")

[commit-bot: I haz the power, 2016-09-09 18:29:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 20:23:02]

Description was changed from

==========
Add UMA for selection drag autoscroll.

BUG=644741
==========

to

==========
Add UMA for selection drag autoscroll.

BUG=644741
==========

[commit-bot: I haz the power, 2016-09-09 20:23:04]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-09-09 20:25:13]

Description was changed from

==========
Add UMA for selection drag autoscroll.

BUG=644741
==========

to

==========
Add UMA for selection drag autoscroll.

BUG=644741

Committed: https://crrev.com/e7bad168e3e78aa062b663adea7988552a7978d6
Cr-Commit-Position: refs/heads/master@{#417689}
==========

[commit-bot: I haz the power, 2016-09-09 20:25:14]

Patchset 4 (id:??) landed as
https://crrev.com/e7bad168e3e78aa062b663adea7988552a7978d6
Cr-Commit-Position: refs/heads/master@{#417689}