Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2319623003: Reorganize Blink IDL build, delete obsolete GYP files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
haraken, Dirk Pranke
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorganize Blink IDL build, delete obsolete GYP files. This removes all gyp files except modules.gypi which is the only one still used. IDL file lists are consolidated into Source/core/core_idl_files.gni and Source/modules/modules_idl_files.gni, eliminating lists in bindings/core and bindings/modules. TBR=dpranke Committed: https://crrev.com/9ab5e5606105b6d8930136095c1b4399b9957160 Cr-Commit-Position: refs/heads/master@{#417030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -4106 lines) Patch
D third_party/WebKit/Source/bindings/bindings.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/core.gni View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/core.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/generated.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/idl.gni View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/generated.gypi View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 3 chunks +50 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/generated.gyp View 1 chunk +0 lines, -236 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/generated.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/idl.gni View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/modules.gni View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/modules.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/generated.gypi View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/v8.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/global_constructors.gypi View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/global_objects.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/interfaces_info_individual.gypi View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/interfaces_info_overall.gypi View 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/scripts.gyp View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/templates.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/build/features.gypi View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/scripts.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/build/win/precompile.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/config.gyp View 1 chunk +0 lines, -150 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 2 chunks +47 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/inspector.gyp View 1 chunk +0 lines, -175 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gni View 2 chunks +1 line, -24 lines 0 comments Download
D third_party/WebKit/Source/modules/modules.gyp View 1 chunk +0 lines, -134 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -569 lines 0 comments Download
D third_party/WebKit/Source/modules/modules_generated.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/modules/modules_generated.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +591 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +0 lines, -437 lines 0 comments Download
D third_party/WebKit/Source/platform/blink_platform_tests.gyp View 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/platform/platform_generated.gyp View 1 chunk +0 lines, -179 lines 0 comments Download
D third_party/WebKit/Source/platform/platform_generated.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +0 lines, -277 lines 0 comments Download
D third_party/WebKit/Source/web/web.gyp View 1 chunk +0 lines, -215 lines 0 comments Download
D third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +0 lines, -172 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319623003/1
4 years, 3 months ago (2016-09-07 17:55:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 19:38:14 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ab5e5606105b6d8930136095c1b4399b9957160 Cr-Commit-Position: refs/heads/master@{#417030}
4 years, 3 months ago (2016-09-07 19:40:29 UTC) #11
haraken
LGTM
4 years, 3 months ago (2016-09-07 23:10:01 UTC) #12
Dirk Pranke
4 years, 3 months ago (2016-09-08 22:07:10 UTC) #13
Message was sent while issue was closed.
rs- lgtm.

Powered by Google App Engine
This is Rietveld 408576698