Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2319623002: Remove calls to IsRunningSequenceOnCurrentThread() from plugin_service_impl.cc (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to IsRunningSequenceOnCurrentThread() from plugin_service_impl.cc SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. Developers should use SequenceChecker to verify that tasks run sequentially. Unlike SequencedWorkerPool::IsRunningSequenceOnCurrentThread(), SequenceChecker works everywhere in Chrome (MessageLoop, SequencedWorkerPool, base/task_scheduler...). BUG=622400 Committed: https://crrev.com/5e1706c38519a9e467769ef549070dcc5c3cdfe2 Cr-Commit-Position: refs/heads/master@{#417266}

Patch Set 1 #

Patch Set 2 : fix test error #

Patch Set 3 : fix android build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 5 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-07 16:57:07 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-08 12:47:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319623002/40001
4 years, 3 months ago (2016-09-08 12:54:06 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 12:57:25 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 12:58:43 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e1706c38519a9e467769ef549070dcc5c3cdfe2
Cr-Commit-Position: refs/heads/master@{#417266}

Powered by Google App Engine
This is Rietveld 408576698