[gn] Switch mac asan to gn

[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true

Committed: https://crrev.com/91426718472657da43668e215b7c9ce4ac295feb
Cr-Commit-Position: refs/heads/master@{#39281}

[Michael Achenbach, 2016-09-08 10:07:50]

Description was changed from

==========
[gn] Switch mac asan to gn

BUG=
==========

to

==========
[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true
==========

[Michael Achenbach, 2016-09-08 12:29:32]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-09-08 12:29:33]

PTAL

Comparison:
https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/8450...

Custom libc++ should not be used on mac. But the files of libc++ are compiled as
well as part of the "all" target. This is different in gn as there simply all
targets in subdirectories seem to be found and part of ninja's "all".

The logic that adds the dependency indicates that it should be off:
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...

https://cs.chromium.org/chromium/src/build/config/sanitizers/sanitizers.gni?l...

Another indication, why it is still off is that the -isystem flags are not
showing up in the comparison above:
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...

Other flags are similar to the other mac bots. Except we only use -O2 now by
design as asan is not guaranteed to work well with -O3.

[Michael Achenbach, 2016-09-08 12:31:54]

On 2016/09/08 12:29:33, machenbach (slow) wrote:
> PTAL
> 
> Comparison:
>
https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/8450...
> 
> Custom libc++ should not be used on mac. But the files of libc++ are compiled
as
> well as part of the "all" target. This is different in gn as there simply all
> targets in subdirectories seem to be found and part of ninja's "all".
> 
> The logic that adds the dependency indicates that it should be off:
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...
> 
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/sanitizers.gni?l...
> 
> Another indication, why it is still off is that the -isystem flags are not
> showing up in the comparison above:
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...
> 
> Other flags are similar to the other mac bots. Except we only use -O2 now by
> design as asan is not guaranteed to work well with -O3.

Another proof that the libc++ dependency is still off, is that the libc++.so is
not in the uploaded isolate of the try run above:
https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=d9dee292...

[Michael Achenbach, 2016-09-08 12:31:54]

On 2016/09/08 12:29:33, machenbach (slow) wrote:
> PTAL
> 
> Comparison:
>
https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/8450...
> 
> Custom libc++ should not be used on mac. But the files of libc++ are compiled
as
> well as part of the "all" target. This is different in gn as there simply all
> targets in subdirectories seem to be found and part of ninja's "all".
> 
> The logic that adds the dependency indicates that it should be off:
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...
> 
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/sanitizers.gni?l...
> 
> Another indication, why it is still off is that the -isystem flags are not
> showing up in the comparison above:
>
https://cs.chromium.org/chromium/src/build/config/sanitizers/BUILD.gn?q=use_c...
> 
> Other flags are similar to the other mac bots. Except we only use -O2 now by
> design as asan is not guaranteed to work well with -O3.

Another proof that the libc++ dependency is still off, is that the libc++.so is
not in the uploaded isolate of the try run above:
https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=d9dee292...

[jochen (gone - plz use gerrit), 2016-09-08 12:35:55]

lgtm

[Michael Achenbach, 2016-09-08 13:09:30]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-09-08 13:09:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 13:11:36]

Description was changed from

==========
[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true
==========

to

==========
[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-08 13:11:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 13:12:15]

Description was changed from

==========
[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true
==========

to

==========
[gn] Switch mac asan to gn

BUG=chromium:644643
NOTRY=true

Committed: https://crrev.com/91426718472657da43668e215b7c9ce4ac295feb
Cr-Commit-Position: refs/heads/master@{#39281}
==========

[commit-bot: I haz the power, 2016-09-08 13:12:16]

Patchset 2 (id:??) landed as
https://crrev.com/91426718472657da43668e215b7c9ce4ac295feb
Cr-Commit-Position: refs/heads/master@{#39281}