ServiceWorker: Shows a warning when adding event handlers asynchronously

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 142 matching lines @@
 void ServiceWorkerGlobalScope::setRegistration(std::unique_ptr<WebServiceWorkerRegistration::Handle> handle)
 {
     if (!getExecutionContext())
         return;
     m_registration = ServiceWorkerRegistration::getOrCreate(getExecutionContext(), wrapUnique(handle.release()));
 }
 
 bool ServiceWorkerGlobalScope::addEventListenerInternal(const AtomicString& eventType, EventListener* listener, const AddEventListenerOptionsResolved& options)
 {
     if (m_didEvaluateScript) {
-        if (eventType == EventTypeNames::install) {
-            ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Event handler of 'install' event must be added on the initial evaluation of worker script.");
-            addConsoleMessage(consoleMessage);
-        } else if (eventType == EventTypeNames::activate) {
-            ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Event handler of 'activate' event must be added on the initial evaluation of worker script.");
-            addConsoleMessage(consoleMessage);
-        }
+        String message = String::format("Event handler of '%s' event must be added on the initial evaluation of worker script.", eventType.ascii().data());

[falken, 2016/09/20 01:46:41]

Maybe I'm paranoid but I'd just utf8() instead of ascii(), performance isn't an
issue for this console warning.

[shimazu, 2016/09/20 06:07:52]

Done.

+        addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
     }
     return WorkerGlobalScope::addEventListenerInternal(eventType, listener, options);
 }
 
 const AtomicString& ServiceWorkerGlobalScope::interfaceName() const
 {
     return EventTargetNames::ServiceWorkerGlobalScope;
 }
 
 DispatchEventResult ServiceWorkerGlobalScope::dispatchEventInternal(Event* event)
@@ skipping 45 matching lines @@
 }
 
 void ServiceWorkerGlobalScope::exceptionThrown(ErrorEvent* event)
 {
     WorkerGlobalScope::exceptionThrown(event);
     if (WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(thread()->isolate()))
         debugger->exceptionThrown(event);
 }
 
 } // namespace blink