Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2319563002: [stubs] Turn CSA::FillFixedArrayWithHole() to CSA::FillFixedArrayWithValue(). (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Turn CSA::FillFixedArrayWithHole() to CSA::FillFixedArrayWithValue(). Committed: https://crrev.com/c20e02e34a0ea18acc9499c2e3c630fc91918133 Cr-Commit-Position: refs/heads/master@{#39247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M src/code-stub-assembler.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 6 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-07 12:26:14 UTC) #6
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-07 12:55:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319563002/20001
4 years, 3 months ago (2016-09-07 12:55:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-07 12:57:27 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 12:58:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c20e02e34a0ea18acc9499c2e3c630fc91918133
Cr-Commit-Position: refs/heads/master@{#39247}

Powered by Google App Engine
This is Rietveld 408576698