Remove NTPSnippetsService::disabled_reason().

Remove disabled_reason() accessors in NTPSnippetsService and NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService might be inaccurate before it has been initialized, so this prevents the initial value from being read.

BUG=634451
Committed: https://crrev.com/9a381311b3fdeb2acbbe304b49f6945d65f2ba83
Cr-Commit-Position: refs/heads/master@{#417275}

[Bernhard Bauer, 2016-09-08 11:43:27]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 11:43:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-09-08 12:30:29]

Description was changed from

==========
Remove NTPSnippetsService::disabled_reason().

BUG=634451
==========

to

==========
Remove disabled_reason() accessors in NTPSnippetsService and
NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService
might be inaccurate before it has been initialized, so this prevents the initial
value from being read.

BUG=634451
==========

[Bernhard Bauer, 2016-09-08 12:31:13]

bauerb@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org, treib@chromium.org

[Bernhard Bauer, 2016-09-08 12:31:14]

PTAL.

Or maybe we should use a base::Optional to indicate that the initial value is
undefined? :)

[Michael van Ouwerkerk, 2016-09-08 12:33:11]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 12:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael van Ouwerkerk, 2016-09-08 12:34:01]

lgtm

[Marc Treib, 2016-09-08 12:49:40]

lgtm

[Bernhard Bauer, 2016-09-08 13:39:45]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-09-08 13:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 13:47:36]

Description was changed from

==========
Remove disabled_reason() accessors in NTPSnippetsService and
NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService
might be inaccurate before it has been initialized, so this prevents the initial
value from being read.

BUG=634451
==========

to

==========
Remove disabled_reason() accessors in NTPSnippetsService and
NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService
might be inaccurate before it has been initialized, so this prevents the initial
value from being read.

BUG=634451
==========

[commit-bot: I haz the power, 2016-09-08 13:47:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 13:49:14]

Description was changed from

==========
Remove disabled_reason() accessors in NTPSnippetsService and
NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService
might be inaccurate before it has been initialized, so this prevents the initial
value from being read.

BUG=634451
==========

to

==========
Remove disabled_reason() accessors in NTPSnippetsService and
NTPSnippetsStatusService.

The accessors are unused, and the initial value in NTPSnippetsStatusService
might be inaccurate before it has been initialized, so this prevents the initial
value from being read.

BUG=634451

Committed: https://crrev.com/9a381311b3fdeb2acbbe304b49f6945d65f2ba83
Cr-Commit-Position: refs/heads/master@{#417275}
==========

[commit-bot: I haz the power, 2016-09-08 13:49:15]

Patchset 2 (id:??) landed as
https://crrev.com/9a381311b3fdeb2acbbe304b49f6945d65f2ba83
Cr-Commit-Position: refs/heads/master@{#417275}