Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2319543003: Remove unused context parameter from JSGetStringFromID (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused context parameter from JSGetStringFromID Clean up before using IDS_STRING_JSBADOBJECT in nearly all JS callbacks, which will happen in the next CL when we watch C-side object destruction. Add a "no permission" message as well. Committed: https://pdfium.googlesource.com/pdfium/+/cd5dc855df0ca37b7667b5f3ceb951d2d417d99f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -201 lines) Patch
M fpdfsdk/javascript/Annot.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 20 chunks +44 lines, -73 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 25 chunks +56 lines, -73 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 12 chunks +21 lines, -29 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/resource.h View 2 chunks +4 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/resource.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/util.cpp View 6 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Tom Sepez
Lei, please review.
4 years, 3 months ago (2016-09-07 23:22:02 UTC) #5
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-08 01:25:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319543003/20001
4 years, 3 months ago (2016-09-08 18:23:09 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:23:27 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cd5dc855df0ca37b7667b5f3ceb951d2d417...

Powered by Google App Engine
This is Rietveld 408576698