Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2319533005: [turbofan] Ensure that all prototypes are stable for push/pop. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure that all prototypes are stable for push/pop. When lowering Array.prototype.push/.pop to the fast inlined version, we first need to ensure that all prototypes (including the Object.prototype) are stable. R=mvstanton@chromium.org BUG=chromium:644689 Committed: https://crrev.com/4ed27fc836acfc3218a5e4ce6d878a513e9df788 Cr-Commit-Position: refs/heads/master@{#39266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +6 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-644689-1.js View 1 chunk +5 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-644689-2.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-08 04:35:05 UTC) #1
Benedikt Meurer
Hey Michael, We didn't properly check the Object.prototype for the Array resize operations. Please take ...
4 years, 3 months ago (2016-09-08 04:36:13 UTC) #4
mvstanton
lgtm
4 years, 3 months ago (2016-09-08 07:59:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319533005/1
4 years, 3 months ago (2016-09-08 08:46:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 08:48:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 08:48:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ed27fc836acfc3218a5e4ce6d878a513e9df788
Cr-Commit-Position: refs/heads/master@{#39266}

Powered by Google App Engine
This is Rietveld 408576698