Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 2319533003: Add more fields to ClientDownloadRequest (Closed)
Patch Set: trailing spaces Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index 1eb1eedd69bec640c05b9d4c015a3bc9cf3d2b48..fc588cc1ffd192e8a18149db831090ed28987d10 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -380,7 +380,46 @@ message ClientDownloadRequest {
// PPAPI_SAVE_REQUEST type messages may have more than one suggested filetype.
// Each element in this collection indicates an alternate extension including
// the leading extension separator.
- repeated string alternate_extensions = 32;
+ repeated string alternate_extensions = 35;
Nathan Parker 2016/09/08 20:23:25 Changing the id... I assume this was this never in
+
+ message URLChainEntry {
+ enum URLType {
+ DOWNLOAD_URL = 1;
+ DOWNLOAD_REFERRER = 2;
+ LANDING_PAGE = 3;
+ LANDING_REFERRER = 4;
+ CLIENT_REDIRECT = 5;
+ SERVER_REDIRECT = 6;
+ }
+
+ // [required] The url of this Entry.
+ optional string url = 1;
+
+ // Type of URLs, such as download url, download referrer, etc.
+ optional URLType type = 2;
+
+ // IP address corresponding to url.
+ optional string ip_address = 3;
+
+ // Referrer url of this entry.
+ optional string referrer = 4;
+
+ // Main frame URL of referrer.
+ optional string main_frame_referrer = 5;
+
+ // If this URL loads in a different tab/frame from previous one.
+ optional bool is_retargeting = 6;
+
+ // If there is a user gesture attached to this transition.
+ optional bool is_user_initiated = 7;
+
+ optional double timestamp_in_millisec = 8;
+ } // End of URLChainEntry
+
+ // URLs transitions from landing referrer to download in reverse chronological
+ // order, i.e. download url comes first in this list, and landing referrer
+ // comes last.
+ repeated URLChainEntry url_chain = 36;
}
message ClientDownloadResponse {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698