content/browser/web_contents/web_contents_view_android.cc - Issue 231953003: Show Ash like <select> popup on Android tablets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_android.cc

diff --git a/content/browser/web_contents/web_contents_view_android.cc b/content/browser/web_contents/web_contents_view_android.cc

index 2cfcd64e91ee87c76c774f5818d30d5f6048a50d..2e9eb2e4c2f34e5fb2d731b305b7e50ad23e1119 100644

--- a/content/browser/web_contents/web_contents_view_android.cc

+++ b/content/browser/web_contents/web_contents_view_android.cc

@@ -183,7 +183,7 @@ void WebContentsViewAndroid::ShowPopupMenu(

bool allow_multiple_selection) {

if (content_view_core_) {

content_view_core_->ShowSelectPopupMenu(

- items, selected_item, allow_multiple_selection);

+ bounds, items, selected_item, allow_multiple_selection);

}