content/browser/android/content_view_core_impl.h - Issue 231953003: Show Ash like <select> popup on Android tablets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index dd39522e1411f07d8977c0d472b297c194ba914f..e1ebb3a9bed82d153d8018e21efe8487b80d2ea4 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -232,7 +232,8 @@ class ContentViewCoreImpl : public ContentViewCore,

// |multiple| defines if it should support multi-select.

// If not |multiple|, |selected_item| sets the initially selected item.

// Otherwise, item's "checked" flag selects it.

- void ShowSelectPopupMenu(const std::vector<MenuItem>& items,

+ void ShowSelectPopupMenu(const gfx::Rect& bounds,

+ const std::vector<MenuItem>& items,

int selected_item,

bool multiple);

// Hides a visible popup menu.