Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx
Patch Set: Introduce DropdownPopupWindow Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
index 2b3a60e290703023e06771a66056aa43aaff7c0b..b5e7283ac163fd92b252d8158817a5b3ac2d17e6 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
@@ -4,11 +4,13 @@
package org.chromium.content.browser.input;
+import org.chromium.ui.DropdownItem;
+
/**
* Select popup item containing the label, the type and the enabled state
* of an item belonging to a select popup dialog.
*/
-public class SelectPopupItem {
+public class SelectPopupItem implements DropdownItem {
private final String mLabel;
private final int mType;
@@ -17,10 +19,21 @@ public class SelectPopupItem {
mType = type;
}
+ @Override
public String getLabel() {
return mLabel;
}
+ @Override
+ public String getSublabel() {
+ return null;
+ }
+
+ @Override
+ public boolean isEnabled() {
+ return mType == PopupItemType.ENABLED || mType == PopupItemType.GROUP;
+ }
+
public int getType() {
return mType;
}

Powered by Google App Engine
This is Rietveld 408576698