content/public/android/java/res/layout/select_popup_item.xml - Issue 231953003: Show Ash like <select> popup on Android tablets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/res/layout/select_popup_item.xml

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2

	3 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

	4 android:id="@+id/label"

	5 android:layout_width="match_parent"

	6 android:layout_height="wrap_content"

	7 android:text="@+id/label"

	8 android:textSize="20dp"

	9 android:gravity="center_vertical"

	10 android:singleLine="true"

	11 android:minHeight="38dp"
	Ted C 2014/04/12 01:10:27 minHeight should be 48dp per android touch guideli minHeight should be 48dp per android touch guidelines. We should also ensure it's at least 48dp wide (and in reality, we should make the minimum something more obvious like 100dp). keishi 2014/04/15 14:41:07 Done. Show quoted text On 2014/04/12 01:10:27, Ted C wrote: > minHeight should be 48dp per android touch guidelines. We should also ensure > it's at least 48dp wide (and in reality, we should make the minimum something > more obvious like 100dp). Done.
	12 android:paddingStart="4dp"

	13 android:paddingEnd="4dp" />

OLD	NEW