content/public/android/java/res/values/dimens.xml - Issue 231953003: Show Ash like <select> popup on Android tablets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/res/values/dimens.xml

Issue 231953003: Show Ash like <select> popup on Android tablets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newpopupx

Patch Set: Introduce DropdownPopupWindow Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <resources>	8 <resources>

9 <!-- Link Preview dimensions -->	9 <!-- Link Preview dimensions -->

10 <dimen name="link_preview_overlay_radius">7dp</dimen>	10 <dimen name="link_preview_overlay_radius">7dp</dimen>

	11 <dimen name="select_popup_horizontal_margin">3dp</dimen>
	aurimas (slooooooooow) 2014/04/16 17:36:48 All these seem to be unused? All these seem to be unused? keishi 2014/04/17 12:25:40 Done. Show quoted text On 2014/04/16 17:36:48, aurimas wrote: > All these seem to be unused? Done.
	12 <dimen name="select_popup_width">300dp</dimen>

	13 <dimen name="select_popup_height">304dp</dimen>

	14 <dimen name="select_popup_border_width">1dp</dimen>

11 </resources>	15 </resources>

OLD	NEW