Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2319513003: //[chrome/browser/]net: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//[chrome/browser/]net: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. R=mmenke@chromium.org BUG=640599 Committed: https://crrev.com/b858232de98dae192ebb70a5a8630cc7e7b98e32 Cr-Commit-Position: refs/heads/master@{#417533}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Patch Set 4 : Just rebased #

Patch Set 5 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -148 lines) Patch
M chrome/browser/net/errorpage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/file_downloader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/net/sdch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/directory_lister_unittest.cc View 7 chunks +7 lines, -9 lines 0 comments Download
M net/base/elements_upload_data_stream_unittest.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 2 chunks +9 lines, -27 lines 0 comments Download
M net/disk_cache/cache_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M net/disk_cache/simple/simple_version_upgrade_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_channel_id_store_unittest.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/transport_security_persister_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/log/bounded_file_net_log_observer_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/log/write_to_file_net_log_observer_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/socket/unix_domain_client_socket_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/unix_domain_server_socket_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_fetcher_response_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job_unittest.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M net/url_request/url_request_file_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
vabr (Chromium)
Hi mmenke@, Could you please review this? It is just a mechanical renaming, no tests ...
4 years, 3 months ago (2016-09-08 13:58:15 UTC) #8
mmenke
On 2016/09/08 13:58:15, vabr (Chromium) wrote: > Hi mmenke@, > > Could you please review ...
4 years, 3 months ago (2016-09-08 14:23:44 UTC) #11
vabr (Chromium)
On 2016/09/08 14:23:44, mmenke wrote: > On 2016/09/08 13:58:15, vabr (Chromium) wrote: > > Hi ...
4 years, 3 months ago (2016-09-09 07:06:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319513003/80001
4 years, 3 months ago (2016-09-09 07:07:05 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-09 08:05:55 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 08:09:18 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b858232de98dae192ebb70a5a8630cc7e7b98e32
Cr-Commit-Position: refs/heads/master@{#417533}

Powered by Google App Engine
This is Rietveld 408576698