Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4902)

Unified Diff: chrome/browser/ui/android/infobars/grouped_permission_infobar.cc

Issue 2319443002: Add InfoBarIdentifier to GroupedPermissionInfoBarDelegate (Closed)
Patch Set: address review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc b/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
index 8f3065532a50d09f84d1b1780eb927f965948b60..627844f8c157588817190cdb205aff2d13b30e36 100644
--- a/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
+++ b/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
@@ -7,10 +7,16 @@
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
+#include "base/memory/ptr_util.h"
#include "chrome/browser/android/resource_mapper.h"
-#include "chrome/browser/permissions/grouped_permission_infobar_delegate.h"
+#include "chrome/browser/permissions/grouped_permission_infobar_delegate_android.h"
#include "jni/GroupedPermissionInfoBar_jni.h"
+std::unique_ptr<infobars::InfoBar> CreateGroupedPermissionInfoBar(
+ std::unique_ptr<GroupedPermissionInfoBarDelegate> delegate) {
+ return base::WrapUnique(new GroupedPermissionInfoBar(std::move(delegate)));
+}
+
GroupedPermissionInfoBar::GroupedPermissionInfoBar(
std::unique_ptr<GroupedPermissionInfoBarDelegate> delegate)
: ConfirmInfoBar(std::move(delegate)) {}
@@ -26,11 +32,10 @@ void GroupedPermissionInfoBar::SetPermissionState(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jbooleanArray>& permissions) {
-
- for (int i = 0; i < GetDelegate()->GetPermissionCount(); i++) {
- jboolean value;
- env->GetBooleanArrayRegion(permissions.obj(), i, 1, &value);
- GetDelegate()->ToggleAccept(i, value);
+ for (size_t i = 0; i < GetDelegate()->GetPermissionCount(); i++) {
+ jboolean value;
+ env->GetBooleanArrayRegion(permissions.obj(), i, 1, &value);
+ GetDelegate()->ToggleAccept(i, value);
}
}
@@ -64,7 +69,7 @@ GroupedPermissionInfoBar::CreateRenderInfoBar(JNIEnv* env) {
std::vector<int> permission_icons;
std::vector<int> content_settings_types;
- for (int i = 0; i < delegate->GetPermissionCount(); i++) {
+ for (size_t i = 0; i < delegate->GetPermissionCount(); i++) {
permission_strings.push_back(delegate->GetMessageTextFragment(i));
permission_icons.push_back(
ResourceMapper::MapFromChromiumId(delegate->GetIconIdForPermission(i)));
@@ -91,11 +96,3 @@ void GroupedPermissionInfoBar::SetJavaInfoBar(
GroupedPermissionInfoBarDelegate* GroupedPermissionInfoBar::GetDelegate() {
return static_cast<GroupedPermissionInfoBarDelegate*>(delegate());
}
-
-std::unique_ptr<infobars::InfoBar>
-GroupedPermissionInfoBarDelegate::CreateInfoBar(
- infobars::InfoBarManager* infobar_manager,
- std::unique_ptr<GroupedPermissionInfoBarDelegate> delegate) {
- return std::unique_ptr<infobars::InfoBar>(
- new GroupedPermissionInfoBar(std::move(delegate)));
-}

Powered by Google App Engine
This is Rietveld 408576698