Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231943005: Rename remoting/protocol/util.h to message_serialization.h (Closed)

Created:
6 years, 8 months ago by Sergey Ulanov
Modified:
6 years, 8 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Rename remoting/protocol/util.h to message_serialization.h Both base and protocol directories had util.cc files, which confuses the linker when compiling them into a single static .a lib. BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262938

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -79 lines) Patch
M remoting/host/video_scheduler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/audio_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/client_control_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/client_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/host_control_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/protocol/message_serialization.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/protocol/message_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/protobuf_video_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/protocol/util.h View 1 chunk +0 lines, -32 lines 0 comments Download
D remoting/protocol/util.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
6 years, 8 months ago (2014-04-10 01:24:16 UTC) #1
rmsousa
lgtm
6 years, 8 months ago (2014-04-10 01:27:54 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-04-10 01:29:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/231943005/20001
6 years, 8 months ago (2014-04-10 01:29:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 02:31:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-10 02:31:18 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-04-10 03:41:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/231943005/20001
6 years, 8 months ago (2014-04-10 03:42:02 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:38:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 262938

Powered by Google App Engine
This is Rietveld 408576698