Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 231943002: [CSS Shapes] Add regions like performance test (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Add regions like performance test Add a performance test that emulates regions but does not actually use them. This is a merge of http://trac.webkit.org/changeset/167022 by Zoltan Horvath <zoltan@webkit.org>;. NOTRY=true BUG=349093 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171392

Patch Set 1 #

Patch Set 2 : Rename to MultipleShapes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -0 lines) Patch
A PerformanceTests/Layout/Shapes/MultipleShapes.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/resources/MultipleShapes.css View 1 1 chunk +82 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth400.html View 1 1 chunk +114 lines, -0 lines 1 comment Download
A PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth600.html View 1 1 chunk +118 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth800.html View 1 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rwlbuis
PTAL :)
6 years, 8 months ago (2014-04-09 21:43:22 UTC) #1
Zoltan
lgtm
6 years, 8 months ago (2014-04-09 23:35:18 UTC) #2
Zoltan
I'm not sure whether clip-path needs -webkit prefix.
6 years, 8 months ago (2014-04-09 23:36:21 UTC) #3
rwlbuis
On 2014/04/09 23:36:21, Zoltan wrote: > I'm not sure whether clip-path needs -webkit prefix. I ...
6 years, 8 months ago (2014-04-10 00:10:54 UTC) #4
rwlbuis
PTAL :)
6 years, 8 months ago (2014-04-10 00:11:12 UTC) #5
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/231943002/diff/20001/PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth400.html File PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth400.html (right): https://codereview.chromium.org/231943002/diff/20001/PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth400.html#newcode36 PerformanceTests/Layout/Shapes/resources/MultipleShapesWidth400.html:36: <p><div id="circleShape" class="shape"></div>Lorem ipsum dolor sit amet, consectetur ...
6 years, 8 months ago (2014-04-11 18:01:02 UTC) #6
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-11 23:46:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/231943002/20001
6 years, 8 months ago (2014-04-11 23:46:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 23:46:20 UTC) #9
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-11 23:46:20 UTC) #10
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-12 01:38:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/231943002/20001
6 years, 8 months ago (2014-04-12 01:38:40 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 01:39:19 UTC) #13
Message was sent while issue was closed.
Change committed as 171392

Powered by Google App Engine
This is Rietveld 408576698