DevTools: Fix race condition in TextPrompt completions

DevTools: Fix race condition in TextPrompt completions
If a _loadCompletions was started while an earlier one was active, the earlier one could still be used.

BUG=none

Committed: https://crrev.com/7255c311ffad11a57e8361ce92bbea8cae710f26
Cr-Commit-Position: refs/heads/master@{#417497}

[einbinder, 2016-09-08 01:09:39]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-09-08 01:09:39]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-09-08 01:09:40]

Ptal

[einbinder, 2016-09-08 01:09:40]

Ptal

[lushnikov, 2016-09-08 14:45:50]

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right):

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:48:
this._completionsCounter = 0;
let's name it _completionRequestId

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:502: * @param
{number} completionsCounter
let's make it the very first one and name it completionRequestId

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:522: if
(this._completionsCounter !== completionsCounter ||
!annotatedCompletions.length) {
let's bail out in the very beginning of the callback - we should not do anything
in case requestId has changed.

[einbinder, 2016-09-08 17:49:16]

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right):

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:48:
this._completionsCounter = 0;
On 2016/09/08 at 14:45:50, lushnikov wrote:
> let's name it _completionRequestId

Done.

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:502: * @param
{number} completionsCounter
On 2016/09/08 at 14:45:50, lushnikov wrote:
> let's make it the very first one and name it completionRequestId

Done.

https://codereview.chromium.org/2319393002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:522: if
(this._completionsCounter !== completionsCounter ||
!annotatedCompletions.length) {
On 2016/09/08 at 14:45:50, lushnikov wrote:
> let's bail out in the very beginning of the callback - we should not do
anything in case requestId has changed.

Done.

[lushnikov, 2016-09-08 21:06:49]

thank you, lgtm

[einbinder, 2016-09-09 02:10:02]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 03:45:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 03:47:53]

Description was changed from

==========
DevTools: Fix race condition in TextPrompt completions
If a _loadCompletions was started while an earlier one was active, the earlier
one could still be used.

BUG=none
==========

to

==========
DevTools: Fix race condition in TextPrompt completions
If a _loadCompletions was started while an earlier one was active, the earlier
one could still be used.

BUG=none

Committed: https://crrev.com/7255c311ffad11a57e8361ce92bbea8cae710f26
Cr-Commit-Position: refs/heads/master@{#417497}
==========

[commit-bot: I haz the power, 2016-09-09 03:47:54]

Patchset 2 (id:??) landed as
https://crrev.com/7255c311ffad11a57e8361ce92bbea8cae710f26
Cr-Commit-Position: refs/heads/master@{#417497}