Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: webrtc/modules/desktop_capture/screen_capturer_unittest.cc

Issue 2319383002: Several minor changes to ScreenCapturerWinMagnifier (Closed)
Patch Set: Add TODO to use include & regular function calls to replace dynamical loaded library Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/screen_capturer_unittest.cc
diff --git a/webrtc/modules/desktop_capture/screen_capturer_unittest.cc b/webrtc/modules/desktop_capture/screen_capturer_unittest.cc
index 5c3671672a63693894dd6cfcedafd54da39b4979..6a70dc23cc73bced72e1ddb438a9b325e7971f2c 100644
--- a/webrtc/modules/desktop_capture/screen_capturer_unittest.cc
+++ b/webrtc/modules/desktop_capture/screen_capturer_unittest.cc
@@ -277,15 +277,14 @@ TEST_F(ScreenCapturerTest, Capture) {
EXPECT_TRUE(it.IsAtEnd());
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegion) {
TestCaptureUpdatedRegion();
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
-// TODO(zijiehe): Find out the reason of failure of this test on trybot.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest, DISABLED_TwoCapturers) {
std::unique_ptr<ScreenCapturer> capturer2 = std::move(capturer_);
SetUp();
@@ -357,8 +356,8 @@ TEST_F(ScreenCapturerTest, UseDirectxCapturerWithSharedBuffers) {
EXPECT_EQ(frame->shared_memory()->id(), kTestSharedMemoryId);
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegionWithDirectxCapturer) {
if (!CreateDirectxCapturer()) {
return;
@@ -367,8 +366,8 @@ TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegionWithDirectxCapturer) {
TestCaptureUpdatedRegion();
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest, DISABLED_TwoDirectxCapturers) {
if (!CreateDirectxCapturer()) {
return;
@@ -379,8 +378,15 @@ TEST_F(ScreenCapturerTest, DISABLED_TwoDirectxCapturers) {
TestCaptureUpdatedRegion({capturer_.get(), capturer2.get()});
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
+TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegionWithMagnifierCapturer) {
+ CreateMagnifierCapturer();
+ TestCaptureUpdatedRegion();
+}
+
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest, DISABLED_TwoMagnifierCapturers) {
CreateMagnifierCapturer();
std::unique_ptr<ScreenCapturer> capturer2 = std::move(capturer_);
@@ -388,8 +394,8 @@ TEST_F(ScreenCapturerTest, DISABLED_TwoMagnifierCapturers) {
TestCaptureUpdatedRegion({capturer_.get(), capturer2.get()});
}
-// Disabled due to being flaky due to the fact that it useds rendering / UI,
-// see webrtc/6366.
+// Disabled due to being flaky due to the fact that it uses rendering / UI, see
+// webrtc/6366.
TEST_F(ScreenCapturerTest,
DISABLED_MaybeCaptureUpdatedRegionWithDirectxCapturer) {
// Even DirectX capturer is not supported in current system, we should be able
« no previous file with comments | « no previous file | webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698