Query the GL limits for the passthrough command buffer.

Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/124fd555aaa6bbf9c15368a417109377a242e414
Cr-Commit-Position: refs/heads/master@{#417377}

[Geoff Lang, 2016-09-08 16:51:39]

Description was changed from

==========
Query the GL limits for the passthrough command buffer.

Refactor the limit query code into a utility function.

BUG=602688
==========

to

==========
Query the GL limits for the passthrough command buffer.

Refactor the limit query code into a utility function.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-08 17:16:42]

Description was changed from

==========
Query the GL limits for the passthrough command buffer.

Refactor the limit query code into a utility function.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-08 17:23:09]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 17:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:34:00]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2016-09-08 18:47:36]

geofflang@chromium.org changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[Geoff Lang, 2016-09-08 18:47:37]

PTAL.  I tried to refactor some of the current command buffer's queries into a
shared function but there is a lot of unneeded emulation there so I ended up
keeping them separate.

[Zhenyao Mo, 2016-09-08 19:04:03]

On 2016/09/08 18:47:37, Geoff Lang wrote:
> PTAL.  I tried to refactor some of the current command buffer's queries into a
> shared function but there is a lot of unneeded emulation there so I ended up
> keeping them separate.

lgtm, but it would be really nice that we can share this code of querying all
the caps.

[piman, 2016-09-08 19:41:16]

LGTM, but agreed with zmo, sharing the FeatureInfo -> Capabilities code seems
like a low hanging fruit.

[Geoff Lang, 2016-09-08 19:46:47]

Agreed, the only way I could think of is to pass function pointers to the
various getters (glGetIntegerv, glGetFloatv, glGetShaderPrecisionFormat, etc)
but it feels cumbersome.  It's high on my priorities to do some refactoring in
the FeatureInfo and Capabilities structures soon, especially as we can
eventually break the assumption that we're on top of desktop GL.

[Geoff Lang, 2016-09-08 19:57:08]

On 2016/09/08 19:46:47, Geoff Lang wrote:
> Agreed, the only way I could think of is to pass function pointers to the
> various getters (glGetIntegerv, glGetFloatv, glGetShaderPrecisionFormat, etc)
> but it feels cumbersome.  It's high on my priorities to do some refactoring in
> the FeatureInfo and Capabilities structures soon, especially as we can
> eventually break the assumption that we're on top of desktop GL.

Going to CQ, will try to make progress on this ASAP.

[Geoff Lang, 2016-09-08 19:57:13]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:03:17]

Description was changed from

==========
Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-08 20:03:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 20:04:51]

Description was changed from

==========
Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Query the GL limits for the passthrough command buffer.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/124fd555aaa6bbf9c15368a417109377a242e414
Cr-Commit-Position: refs/heads/master@{#417377}
==========

[commit-bot: I haz the power, 2016-09-08 20:04:52]

Patchset 3 (id:??) landed as
https://crrev.com/124fd555aaa6bbf9c15368a417109377a242e414
Cr-Commit-Position: refs/heads/master@{#417377}