Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2319343003: Switch to ValueOrDie (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Switch to ValueOrDie We know the values are always valid at this point, so use ValueOrDie instead of ValueOrDefault. BUG=chromium:637984 Committed: https://pdfium.googlesource.com/pdfium/+/d827111fb10c7d8b89bc954ab0934b4009d6643c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-08 13:06:44 UTC) #4
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-08 16:41:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319343003/1
4 years, 3 months ago (2016-09-08 17:15:41 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:15:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d827111fb10c7d8b89bc954ab0934b4009d6...

Powered by Google App Engine
This is Rietveld 408576698