content/browser/android/content_view_core_impl.cc - Issue 231933006: Move ExternalVideoSurfaceHolder from WebContents UserData to BrowserMediaPlayerManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 231933006: Move ExternalVideoSurfaceHolder from WebContents UserData to BrowserMediaPlayerManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/lib/main/aw_main_delegate.cc ('K') | « android_webview/native/external_video_surface_container_impl.cc ('k') | content/browser/media/android/browser_media_player_manager.h » ('j') | content/browser/media/android/browser_media_player_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 8606d5cd47712beb0675f21298f964e653eb0415..765af71984dde40c4f893b2163c9850359433b1d 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -38,7 +38,6 @@

#include "content/common/input/web_input_event_traits.h"

#include "content/common/input_messages.h"

#include "content/common/view_messages.h"

-#include "content/public/browser/android/external_video_surface_container.h"

#include "content/public/browser/browser_accessibility_state.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/favicon_status.h"

@@ -489,12 +488,6 @@ void ContentViewCoreImpl::UpdateFrameInfo(

controls_offset.y(),

content_offset.y(),

overdraw_bottom_height);

-#if defined(VIDEO_HOLE)

- ExternalVideoSurfaceContainer* surface_container =

- ExternalVideoSurfaceContainer::FromWebContents(web_contents_);

- if (surface_container)

- surface_container->OnFrameInfoUpdated();

-#endif // defined(VIDEO_HOLE)

}

void ContentViewCoreImpl::SetTitle(const base::string16& title) {