LayoutTests/editing/execCommand/indent-images-3.html - Issue 231933004: Fix a broken test which calls Selection.setPosition(null).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/execCommand/indent-images-3.html

Issue 231933004: Fix a broken test which calls Selection.setPosition(null). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/execCommand/indent-images-3.html

diff --git a/LayoutTests/editing/execCommand/indent-images-3.html b/LayoutTests/editing/execCommand/indent-images-3.html

index 12f9adbbd2e64af3749d163f62b27f94f1fb31d0..c61f7473d6b54fc8c0dff2f7bcc1ac9162002ef2 100644

--- a/LayoutTests/editing/execCommand/indent-images-3.html

+++ b/LayoutTests/editing/execCommand/indent-images-3.html

@@ -10,11 +10,11 @@ if (window.testRunner)

while (script = document.querySelector('script'))

script.parentNode.removeChild(script);

-getSelection().setPosition(document.getElementsByTagName('div')[0], 2);

+getSelection().setPosition(document.getElementsByTagName('span')[0], 2);

document.execCommand('indent');

Markup.description('This test indents insides a document with exactly two image elements.\n'

-+ 'Indentation should fail because the root editable element is inline.');

++ 'Indentation should success even if the root editable element is inline.');

Yuta Kitamura 2014/04/16 01:52:26 nit: success -> succeed

yoichio 2014/04/16 03:17:02 Done.

Markup.dump(document.body);

</script>

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/indent-images-3-expected.txt » ('j') | no next file with comments »