Issue 231933002: Merge 262312 "[Android] Use latest page scale factor when comput..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231933002: Merge 262312 "[Android] Use latest page scale factor when comput..." (Closed)

Created:
6 years, 8 months ago by jdduke (slow)

Modified:
6 years, 8 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

More Reviews

Description

Merge 262312 "[Android] Use latest page scale factor when comput..." > [Android] Use latest page scale factor when computing content width > > Previously, ContentViewCore clamped the effective content bounds from the > compositor frame metadata using the *previous* frame's page scale factor. > Instead, clamp the content bounds using the *current* frame's page scale > factor, and make the content viewport comparison more robust. This fixes an > issue where the content size after page load was being improperly calculated, > preventing mobile sites (e.g., width=device-width) from benefiting from the > disabled tap delay. > > BUG=360602 > > Review URL: https://codereview.chromium.org/224723019 TBR=jdduke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262814

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		2 chunks	+3 lines, -4 lines	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r262814.

Expand Messages | Collapse Messages