ui/native_theme/native_theme_dark_aura.cc - Issue 2319313003: views: refactor away PlatformStyle::BackgroundColorForMdButton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_dark_aura.cc

Issue 2319313003: views: refactor away PlatformStyle::BackgroundColorForMdButton (Closed)

Patch Set: fix nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/native_theme/native_theme_dark_aura.cc

diff --git a/ui/native_theme/native_theme_dark_aura.cc b/ui/native_theme/native_theme_dark_aura.cc

index 443d955642302b7fb153e96ea8dacf7195cd9f92..b565741a1c48ec45138a1173e2d2f6f56a92d7ba 100644

--- a/ui/native_theme/native_theme_dark_aura.cc

+++ b/ui/native_theme/native_theme_dark_aura.cc

@@ -96,6 +96,7 @@ SkColor NativeThemeDarkAura::GetSystemColor(ColorId color_id) const {

case kColorId_ResultsTableNormalUrl:

case kColorId_ResultsTableHoveredUrl:

case kColorId_ResultsTableSelectedUrl:

+ case kColorId_ButtonPressedShade:

Evan Stade 2016/09/08 16:36:49 nit: perhaps keep these in declaration order? i.e.

return NativeThemeAura::GetSystemColor(color_id);

// Any other color is not defined and shouldn't be used in a dark theme.

« no previous file with comments | « ui/native_theme/native_theme.h ('k') | ui/native_theme/native_theme_mac.mm » ('j') | no next file with comments »