Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/app/generated_resources.grd

Issue 2319303002: Bug Fix: Title Case for Picker Window Title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 300d7c522f180fac670c65f52d48989e5b03f7e2..2ae8cf41ae660b61d8bb0ee0424cc85ba11a9065 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -13909,6 +13909,9 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
<message name="IDS_DESKTOP_MEDIA_PICKER_TITLE" desc="Title for the window picker dialog shown when desktop capture is requested by an app.">
Share your screen
</message>
+ <message name="IDS_DESKTOP_MEDIA_PICKER_TITLE_MAC" desc="Title for the window picker dialog shown when desktop capture is requested by an app.">
msw 2016/09/07 22:39:22 Follow the <if expr="use_titlecase"> pattern of ot
qiangchen 2016/09/08 16:46:03 Tested, and I found this way works. But I am curi
msw 2016/09/08 20:14:10 Each platform sets the use_titlecase build flag va
qiangchen 2016/09/08 21:37:41 Acknowledged.
+ Share Your Screen
+ </message>
<message name="IDS_DESKTOP_MEDIA_PICKER_TITLE_DEPRECATED" desc="Title for the window picker dialog shown when desktop capture is requested by an app.">
Share your screen - <ph name="APP_NAME">$1<ex>Google Hangouts</ex></ph>
</message>
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698