Chromium Code Reviews Chromium Code Reviews
Issue 2319303002:
Bug Fix: Title Case for Picker Window Title (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/app/generated_resources.grd |
| diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd |
| index 300d7c522f180fac670c65f52d48989e5b03f7e2..1932a39d7b81a43f70bb0bd5f2c1e49ebe91de44 100644 |
| --- a/chrome/app/generated_resources.grd |
| +++ b/chrome/app/generated_resources.grd |
| @@ -13906,9 +13906,16 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex |
| </message> |
| <!-- Desktop media picker UI for Desktop Capture API --> |
| + <if expr="not use_titlecase"> |
| <message name="IDS_DESKTOP_MEDIA_PICKER_TITLE" desc="Title for the window picker dialog shown when desktop capture is requested by an app."> |
|
msw
2016/09/08 20:14:11
nit: fix indentation
|
| Share your screen |
| </message> |
| + </if> |
| + <if expr="use_titlecase"> |
| + <message name="IDS_DESKTOP_MEDIA_PICKER_TITLE" desc="Title for the window picker dialog shown when desktop capture is requested by an app."> |
|
msw
2016/09/08 20:14:10
ditto nit: fix indentation
|
| + Share Your Screen |
|
msw
2016/09/08 20:14:11
nit: this should be indented by two spaces from th
|
| + </message> |
| + </if> |
| <message name="IDS_DESKTOP_MEDIA_PICKER_TITLE_DEPRECATED" desc="Title for the window picker dialog shown when desktop capture is requested by an app."> |
| Share your screen - <ph name="APP_NAME">$1<ex>Google Hangouts</ex></ph> |
| </message> |
