Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tools/variations/fieldtrial_to_struct.py

Issue 2319293006: Use Study and Experiment Terminology on the C++ Side For Fieldtrials (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/variations/fieldtrial_to_struct.py
diff --git a/tools/variations/fieldtrial_to_struct.py b/tools/variations/fieldtrial_to_struct.py
index bfea4e4a2f9d1d39ce2380e663d109aabf2efe6f..132f0aa1ca154322f8ac7f7a31a6b687e3e8973d 100755
--- a/tools/variations/fieldtrial_to_struct.py
+++ b/tools/variations/fieldtrial_to_struct.py
@@ -61,24 +61,24 @@ def _CreateTrial(study_name, experiment_configs, platform):
platform_experiment_lists))
return {
'name': study_name,
- 'groups': [_CreateExperiment(experiment)
- for experiment in platform_experiments],
+ 'experiments': [_CreateExperiment(experiment)
+ for experiment in platform_experiments],
}
def _GenerateTrials(config, platform):
for study_name in sorted(config.keys()):
study = _CreateTrial(study_name, config[study_name], platform)
- # To avoid converting studies with empty groups (e.g. the study doesn't
+ # To avoid converting studies with empty experiments (e.g. the study doesn't
# apply to the target platform), this generator only yields studies that
- # have non-empty groups.
- if study['groups']:
+ # have non-empty experiments.
+ if study['experiments']:
yield study
def _FieldTrialConfigToDescription(config, platform):
return {
'elements': {
'kFieldTrialConfig': {
- 'trials': [study for study in _GenerateTrials(config, platform)]
+ 'studies': [study for study in _GenerateTrials(config, platform)]
}
}
}
« no previous file with comments | « chrome/common/variations/variations_util_unittest.cc ('k') | tools/variations/fieldtrial_to_struct_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698