Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2319293006: Use Study and Experiment Terminology on the C++ Side For Fieldtrials (Closed)

Created:
4 years, 3 months ago by robliao
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Study and Experiment Terminology on the C++ Side For Fieldtrials No functionality should change with this change. BUG=637095 Committed: https://crrev.com/045eddd2fa4b852501195757b791ca8b44725bf7 Cr-Commit-Position: refs/heads/master@{#421242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -68 lines) Patch
M chrome/common/variations/fieldtrial_testing_config_schema.json View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/variations/variations_util.cc View 2 chunks +22 lines, -20 lines 0 comments Download
M chrome/common/variations/variations_util_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M tools/variations/fieldtrial_to_struct.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/variations/fieldtrial_to_struct_unittest.py View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/variations/unittest_data/expected_output.h View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/variations/unittest_data/expected_output.cc View 6 chunks +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (29 generated)
robliao
asvitkine: Please review this CL. Thanks!
4 years, 3 months ago (2016-09-20 01:01:10 UTC) #22
Alexei Svitkine (slow)
LGTM Does the server-side code already support the new terminology?
4 years, 2 months ago (2016-09-23 15:20:35 UTC) #25
robliao
On 2016/09/23 15:20:35, Alexei Svitkine (very slow) wrote: > LGTM > > Does the server-side ...
4 years, 2 months ago (2016-09-23 23:05:59 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319293006/60001
4 years, 2 months ago (2016-09-27 17:06:59 UTC) #32
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 2 months ago (2016-09-27 17:13:32 UTC) #33
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:15:51 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/045eddd2fa4b852501195757b791ca8b44725bf7
Cr-Commit-Position: refs/heads/master@{#421242}

Powered by Google App Engine
This is Rietveld 408576698