Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

Issue 2319293004: Replace FilterEffect::maxEffectRect() with absoluteBounds() (Closed)
Patch Set: Add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
index c895217ac7d606a497e257b0713acef0c26bc850..e3fe5ed731885efa863a60f29ad2101999f20922 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
@@ -67,7 +67,8 @@ public:
IntRect absolutePaintRect() const { return m_absolutePaintRect; }
- FloatRect maxEffectRect() const { return m_maxEffectRect; }
+ // Clipped primitive subregion in the coordinate space of the target.
+ FloatRect absoluteBounds() const;
virtual sk_sp<SkImageFilter> createImageFilter();
virtual sk_sp<SkImageFilter> createImageFilterWithoutValidation();
@@ -105,8 +106,6 @@ public:
ColorSpace operatingColorSpace() const { return m_operatingColorSpace; }
virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColorSpace = colorSpace; }
- FloatRect determineMaximumEffectRect();
-
virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect);
virtual bool affectsTransparentPixels() { return false; }
@@ -138,9 +137,6 @@ private:
IntRect m_absolutePaintRect;
- // The maximum size of a filter primitive. In SVG this is the primitive subregion in absolute coordinate space.
- // The absolute paint rect should never be bigger than m_maxEffectRect.
- FloatRect m_maxEffectRect;
Member<Filter> m_filter;
// The following member variables are SVG specific and will move to LayoutSVGResourceFilterPrimitive.

Powered by Google App Engine
This is Rietveld 408576698