src/codec/SkBmpRLECodec.cpp - Issue 2319293003: Checking for valid colorType, alphaType, colorSpace in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpRLECodec.cpp

Issue 2319293003: Checking for valid colorType, alphaType, colorSpace in SkCodec (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpRLECodec.cpp

diff --git a/src/codec/SkBmpRLECodec.cpp b/src/codec/SkBmpRLECodec.cpp

index 02b42f6d90ce086496c6a15dbba8d1bd4cd31c9d..43b189c68e820a8c0754d6a3c28dfb9c7bec84ab 100644

--- a/src/codec/SkBmpRLECodec.cpp

+++ b/src/codec/SkBmpRLECodec.cpp

@@ -44,7 +44,7 @@ SkCodec::Result SkBmpRLECodec::onGetPixels(const SkImageInfo& dstInfo,

// Subsets are not supported.

return kUnimplemented;

}

- if (!conversion_possible(dstInfo, this->getInfo())) {

+ if (!legacy_conversion_possible(dstInfo, this->getInfo())) {

SkCodecPrintf("Error: cannot convert input type to output type.\n");

return kInvalidConversion;

}