Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/812a431578014239af1444e2967413140ab516de
Cr-Commit-Position: refs/heads/master@{#417112}

[Xianzhu, 2016-09-07 21:26:05]

Description was changed from

==========
Workaround of PaintControllerUnderInvalidationTest.MoreDrawing for some builds

On some builds, the death test fails to catch the the failure message
of CHECK failure. Workaround this by not matching the message.
Death expectation is enough for the purpose of the test.

BUG=644768
==========

to

==========
Workaround of PaintControllerUnderInvalidationTest.MoreDrawing for some builds

On some builds, the death test fails to catch the the failure message
of CHECK failure. Workaround this by not matching the message.
Death expectation is enough for the purpose of the test.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-07 21:26:21]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-09-07 21:46:24]

Description was changed from

==========
Workaround of PaintControllerUnderInvalidationTest.MoreDrawing for some builds

On some builds, the death test fails to catch the the failure message
of CHECK failure. Workaround this by not matching the message.
Death expectation is enough for the purpose of the test.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.
Separate LOG and CHECK.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-07 21:47:37]

Description was changed from

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.
Separate LOG and CHECK.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.
Separate LOG and CHECK.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-07 21:48:10]

Description was changed from

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.
Separate LOG and CHECK.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-07 21:48:16]

Patchset #2 (id:20001) has been deleted

[pdr., 2016-09-07 21:50:09]

On 2016/09/07 at 21:26:22, wangxianzhu wrote:
> 

LGTM

Should we file a bug or comment this? It looks like a lot of the other
EXPECT_DEATH calls also use an empty string, probably for the same reason.

[Xianzhu, 2016-09-07 21:52:22]

On 2016/09/07 21:50:09, pdr. wrote:
> On 2016/09/07 at 21:26:22, wangxianzhu wrote:
> > 
> 
> LGTM
> 
> Should we file a bug or comment this? It looks like a lot of the other
> EXPECT_DEATH calls also use an empty string, probably for the same reason.

hans@ just answered the question and I updated the description: official build
just crashes without outputing anything for CHECK failures.

[Xianzhu, 2016-09-07 21:52:51]

On 2016/09/07 21:52:22, Xianzhu wrote:
> On 2016/09/07 21:50:09, pdr. wrote:
> > On 2016/09/07 at 21:26:22, wangxianzhu wrote:
> > > 
> > 
> > LGTM
> > 
> > Should we file a bug or comment this? It looks like a lot of the other
> > EXPECT_DEATH calls also use an empty string, probably for the same reason.
> 
> hans@ just answered the question and I updated the description: official build
> just crashes without outputing anything for CHECK failures.

s/hans/thakis/

[Xianzhu, 2016-09-07 21:53:05]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:53:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:18:17]

Description was changed from

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-07 23:18:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 23:20:27]

Description was changed from

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintControllerUnderInvalidationTest.MoreDrawing on official builds

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/812a431578014239af1444e2967413140ab516de
Cr-Commit-Position: refs/heads/master@{#417112}
==========

[commit-bot: I haz the power, 2016-09-07 23:20:28]

Patchset 1 (id:??) landed as
https://crrev.com/812a431578014239af1444e2967413140ab516de
Cr-Commit-Position: refs/heads/master@{#417112}