Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2319253002: Merge duplicate conditionals in chrome/browser/BUILD.gn. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge duplicate conditionals in chrome/browser/BUILD.gn. Committed: https://crrev.com/d1269b49a5a31b02371a1ce32b53e93c6aa684f4 Cr-Commit-Position: refs/heads/master@{#417481}

Patch Set 1 #

Patch Set 2 : dedup, fix build #

Patch Set 3 : rebase #

Patch Set 4 : Fix bad merge #

Patch Set 5 : Fix more bad merge #

Patch Set 6 : Fix yet more merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -145 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 31 chunks +104 lines, -145 lines 0 comments Download

Messages

Total messages: 41 (28 generated)
Lei Zhang
4 years, 3 months ago (2016-09-07 22:07:32 UTC) #8
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-08 22:06:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319253002/20001
4 years, 3 months ago (2016-09-08 22:07:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/265593) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 22:11:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319253002/40001
4 years, 3 months ago (2016-09-08 22:26:40 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/260241) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 22:31:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319253002/80001
4 years, 3 months ago (2016-09-08 22:47:51 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/260253) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 22:52:52 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319253002/100001
4 years, 3 months ago (2016-09-08 22:57:11 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/197086)
4 years, 3 months ago (2016-09-08 23:08:25 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319253002/120001
4 years, 3 months ago (2016-09-09 01:26:27 UTC) #38
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 3 months ago (2016-09-09 02:33:21 UTC) #39
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 02:35:30 UTC) #41
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d1269b49a5a31b02371a1ce32b53e93c6aa684f4
Cr-Commit-Position: refs/heads/master@{#417481}

Powered by Google App Engine
This is Rietveld 408576698