Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231923002: Move blob_storage_host from webkit/ to content/ (Closed)

Created:
6 years, 8 months ago by pilgrim_google
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik
Visibility:
Public.

Description

Move blob_storage_host from webkit/ to content/ BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262978

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -414 lines) Patch
A + content/browser/fileapi/blob_storage_context_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/fileapi/blob_storage_host.h View 1 3 chunks +12 lines, -7 lines 0 comments Download
A + content/browser/fileapi/blob_storage_host.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 3 chunks +1 line, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 2 chunks +5 lines, -1 line 0 comments Download
D webkit/browser/blob/blob_storage_context_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D webkit/browser/blob/blob_storage_host.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webkit/browser/blob/blob_storage_host.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M webkit/storage_browser.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
6 years, 8 months ago (2014-04-09 21:22:41 UTC) #1
jam
lgtm https://codereview.chromium.org/231923002/diff/1/content/browser/fileapi/blob_storage_host.h File content/browser/fileapi/blob_storage_host.h (right): https://codereview.chromium.org/231923002/diff/1/content/browser/fileapi/blob_storage_host.h#newcode5 content/browser/fileapi/blob_storage_host.h:5: #ifndef CONTENT_BROWSER_BLOB_BLOB_STORAGE_HOST_H_ nit: CONTENT_BROWSER_FILEAPI_BLOB_STORAGE_HOST_H_
6 years, 8 months ago (2014-04-09 22:22:28 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 8 months ago (2014-04-10 00:09:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/231923002/20001
6 years, 8 months ago (2014-04-10 00:10:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 02:50:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=295478
6 years, 8 months ago (2014-04-10 02:50:41 UTC) #6
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 8 months ago (2014-04-10 13:05:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/231923002/20001
6 years, 8 months ago (2014-04-10 13:05:48 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:59:16 UTC) #9
Message was sent while issue was closed. 
Change committed as 262978

Powered by Google App Engine
This is Rietveld 408576698