Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2319223004: GPU driver bug list: Remove Linux Intel occlusion queries workaround (Closed)

Created:
4 years, 3 months ago by Corentin Wallez
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU driver bug list: Remove Linux Intel occlusion queries workaround The relevant WebGL2 CTS tests work fine on recent Intel drivers. BUG=590870 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b358646432848ce6d8954fa28bd7833e51ebbc7c Cr-Commit-Position: refs/heads/master@{#417594}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change version of JSON #

Patch Set 3 : Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 o… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 2 chunks +21 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Corentin Wallez
PTAL!
4 years, 3 months ago (2016-09-08 19:43:42 UTC) #3
Zhenyao Mo
On 2016/09/08 19:43:42, Corentin Wallez wrote: > PTAL! lgtm as far as you've tested it.
4 years, 3 months ago (2016-09-08 19:50:37 UTC) #4
Zhenyao Mo
https://codereview.chromium.org/2319223004/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2319223004/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.94", Please update the version though.
4 years, 3 months ago (2016-09-08 19:51:08 UTC) #5
Corentin Wallez
On 2016/09/08 at 19:50:37, zmo wrote: > On 2016/09/08 19:43:42, Corentin Wallez wrote: > > ...
4 years, 3 months ago (2016-09-08 19:51:38 UTC) #6
Zhenyao Mo
On 2016/09/08 19:51:38, Corentin Wallez wrote: > On 2016/09/08 at 19:50:37, zmo wrote: > > ...
4 years, 3 months ago (2016-09-08 19:52:16 UTC) #7
Corentin Wallez
On 2016/09/08 at 19:52:16, zmo wrote: > On 2016/09/08 19:51:38, Corentin Wallez wrote: > > ...
4 years, 3 months ago (2016-09-09 14:52:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319223004/20001
4 years, 3 months ago (2016-09-09 14:52:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 16:03:33 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:05:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b358646432848ce6d8954fa28bd7833e51ebbc7c
Cr-Commit-Position: refs/heads/master@{#417594}

Powered by Google App Engine
This is Rietveld 408576698