[Download Home] Deal with the infinite spinny

[Download Home] Deal with the infinite spinny

Because of timing delays, and because cancelling a Runnable doesn't
guarantee that it won't run, the LoadingView can get into a state
where it posts a task to animate itself showing up on screen but it
doesn't re-check if it still needs to be visible.

BUG=641262
Committed: https://crrev.com/6c58549cb4351011549394678194bc4c4a5f467a
Cr-Commit-Position: refs/heads/master@{#417417}

[gone, 2016-09-08 21:18:19]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ian Wen, 2016-09-08 21:23:50]

lgtm after comment

https://codereview.chromium.org/2319213004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/widget/LoadingView.java
(right):

https://codereview.chromium.org/2319213004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/LoadingView.java:36:
private boolean mShouldShow;
Could you add some comments above this variable to explain why we need to add
this boolean?

[Ian Wen, 2016-09-08 21:24:24]

BTW thanks for finding this out!!!! This bug is very hard to repro! :)

[gone, 2016-09-08 21:31:59]

https://codereview.chromium.org/2319213004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/widget/LoadingView.java
(right):

https://codereview.chromium.org/2319213004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/LoadingView.java:36:
private boolean mShouldShow;
On 2016/09/08 21:23:50, Ian Wen wrote:
> Could you add some comments above this variable to explain why we need to add
> this boolean?

Done.

[gone, 2016-09-08 21:32:02]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-08 21:32:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2319213004/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2016-09-08 21:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:27:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 22:30:15]

Description was changed from

==========
[Download Home] Deal with the infinite spinny

Because of timing delays, and because cancelling a Runnable doesn't
guarantee that it won't run, the LoadingView can get into a state
where it posts a task to animate itself showing up on screen but it
doesn't re-check if it still needs to be visible.

BUG=641262
==========

to

==========
[Download Home] Deal with the infinite spinny

Because of timing delays, and because cancelling a Runnable doesn't
guarantee that it won't run, the LoadingView can get into a state
where it posts a task to animate itself showing up on screen but it
doesn't re-check if it still needs to be visible.

BUG=641262

Committed: https://crrev.com/6c58549cb4351011549394678194bc4c4a5f467a
Cr-Commit-Position: refs/heads/master@{#417417}
==========

[commit-bot: I haz the power, 2016-09-08 22:30:16]

Patchset 2 (id:??) landed as
https://crrev.com/6c58549cb4351011549394678194bc4c4a5f467a
Cr-Commit-Position: refs/heads/master@{#417417}