Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2319213003: [wasm] Do not produce code for br_if if its condition does not validate. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do not produce code for br_if if its condition does not validate. I could not reproduce the bug in either a unittest nor a cctest. That's why I created an mjsunit test now. BUG=chromium:644682 R=titzer@chromium.org Committed: https://crrev.com/853892a516d3840c7dbec678310817778f09923b Cr-Commit-Position: refs/heads/master@{#39282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/wasm/ast-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/wasm/regression-644682.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-09-08 14:02:37 UTC) #1
titzer
lgtm
4 years, 3 months ago (2016-09-08 14:05:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319213003/1
4 years, 3 months ago (2016-09-08 14:38:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:40:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:41:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/853892a516d3840c7dbec678310817778f09923b
Cr-Commit-Position: refs/heads/master@{#39282}

Powered by Google App Engine
This is Rietveld 408576698