DevTools: Add devtools for tryserver.chromium.linux

DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previous CL:
https://crrev.com/2315983002

BUG=642046
Committed: https://chromium.googlesource.com/chromium/tools/build/+/156cd97e26e5aaca148b26fcf70371e30eac4ebf

[chenwilliam, 2016-09-07 19:01:36]

Description was changed from

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previou CL:
crrev.com/2315983002

BUG=642046
==========

to

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previou CL:
https://crrev.com/2315983002

BUG=642046
==========

[chenwilliam, 2016-09-07 19:01:51]

Description was changed from

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previou CL:
https://crrev.com/2315983002

BUG=642046
==========

to

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previous CL:
https://crrev.com/2315983002

BUG=642046
==========

[chenwilliam, 2016-09-07 19:02:09]

chenwilliam@chromium.org changed reviewers:
+ hinoka@chromium.org, iannucci@chromium.org

[chenwilliam, 2016-09-07 19:02:10]

PTAL. Besides updating chromium/src/infra/config/cq.cfg, 
is there any other configs I need to update before devtools 
will become a CQ experiment? Thanks.

[chenwilliam, 2016-09-07 19:02:35]

The CQ bit was checked by chenwilliam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:02:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:02:46]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[iannucci, 2016-09-08 17:21:27]

lgtm

https://codereview.chromium.org/2319213002/diff/20001/scripts/slave/recipes/d...
File scripts/slave/recipes/devtools.py (right):

https://codereview.chromium.org/2319213002/diff/20001/scripts/slave/recipes/d...
scripts/slave/recipes/devtools.py:48: api.step('skip checks', ['echo', 'no
devtools file in patch'])
result = api.step('skip checks', [...])
result.presentation.step_text = "No devtools files in patch."
return

will add extra explanatory step to the text on the main UI.

[chenwilliam, 2016-09-08 17:36:06]

https://codereview.chromium.org/2319213002/diff/20001/scripts/slave/recipes/d...
File scripts/slave/recipes/devtools.py (right):

https://codereview.chromium.org/2319213002/diff/20001/scripts/slave/recipes/d...
scripts/slave/recipes/devtools.py:48: api.step('skip checks', ['echo', 'no
devtools file in patch'])
On 2016/09/08 17:21:26, iannucci wrote:
> result = api.step('skip checks', [...])
> result.presentation.step_text = "No devtools files in patch."
> return
> 
> will add extra explanatory step to the text on the main UI.

Done.

[chenwilliam, 2016-09-08 17:36:14]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-09-08 17:36:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2319213002/#ps40001
(title: "CL feedback")

[commit-bot: I haz the power, 2016-09-08 17:36:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:40:43]

Description was changed from

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previous CL:
https://crrev.com/2315983002

BUG=642046
==========

to

==========
DevTools: Add devtools for tryserver.chromium.linux

I will open a f/u CL for chromium/src/infra/config/cq.cfg to add devtools
as a CQ experiment.

I also cleaned up tests that I worked on in my previous CL:
https://crrev.com/2315983002

BUG=642046

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/156cd97e26e5aaca148b...
==========

[commit-bot: I haz the power, 2016-09-08 17:40:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/156cd97e26e5aaca148b...