Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2319203002: Clean up RegExp comments and test262 status (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
jgruber, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up RegExp comments and test262 status This patch fixes a bunch of out-of-date TODOs, un-skips some tests and refers to appropriate bug numbers and current specification status where appropriate. R=adamk Committed: https://crrev.com/46edbd164dbe3e0e246ef1c281740efcf4371f5d Cr-Commit-Position: refs/heads/master@{#39260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -33 lines) Patch
M src/js/regexp.js View 11 chunks +8 lines, -23 lines 0 comments Download
M test/test262/test262.status View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-07 18:28:17 UTC) #3
adamk
lgtm
4 years, 3 months ago (2016-09-07 18:36:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319203002/1
4 years, 3 months ago (2016-09-07 18:42:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/3795)
4 years, 3 months ago (2016-09-07 19:09:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319203002/1
4 years, 3 months ago (2016-09-07 19:29:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 19:39:55 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:40:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46edbd164dbe3e0e246ef1c281740efcf4371f5d
Cr-Commit-Position: refs/heads/master@{#39260}

Powered by Google App Engine
This is Rietveld 408576698