Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2319193002: More Harmony combobox/textfield updates: (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More Harmony combobox/textfield updates: Textfields: - handle disabled state for text, border Comboboxes: - update enabled text color (matches textfield) - handle disabled state for text, arrow, border (matches textfield) - draw a solid background so that subpixel aa works BUG=644709, 635164, 635160 Committed: https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a Cr-Commit-Position: refs/heads/master@{#417093}

Patch Set 1 #

Patch Set 2 : textfields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -26 lines) Patch
M ui/native_theme/common_theme.cc View 1 chunk +21 lines, -4 lines 0 comments Download
M ui/views/controls/combobox/combobox.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 4 chunks +30 lines, -9 lines 0 comments Download
M ui/views/controls/focusable_border.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/textfield_example.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 1 5 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Evan Stade
4 years, 3 months ago (2016-09-07 19:10:58 UTC) #7
sky
LGTM
4 years, 3 months ago (2016-09-07 21:30:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319193002/20001
4 years, 3 months ago (2016-09-07 22:18:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:23:31 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:26:44 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a
Cr-Commit-Position: refs/heads/master@{#417093}

Powered by Google App Engine
This is Rietveld 408576698