Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2319143004: If tab is created from chrome UI, don't mark the tab as external app (Closed)
Patch Set: making createNewTab public Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index e4516704b844dbf988ed4a45b330130a1d1772ca..2166412d36cb226fc5e8ef46ca110c9b27e06f36 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -1215,7 +1215,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
// - we decided to close the tab, but it was opened by an external app, so we will go
// exit Chrome on top of closing the tab
final boolean minimizeApp = !shouldCloseTab || currentTab.isCreatedForExternalApp();
-
if (minimizeApp) {
if (shouldCloseTab) {
recordBackPressedUma("Minimized and closed tab", BACK_PRESSED_MINIMIZED_TAB_CLOSED);
@@ -1293,12 +1292,15 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
IntentHandler.EXTRA_OPEN_NEW_INCOGNITO_TAB, false);
boolean fromLauncherShortcut = IntentUtils.safeGetBooleanExtra(
intent, IntentHandler.EXTRA_INVOKED_FROM_SHORTCUT, false);
- return getTabCreator(isIncognito).launchUrl(
- url,
+ LoadUrlParams loadUrlParams = new LoadUrlParams(url);
+ loadUrlParams.setIntentReceivedTimestamp(mIntentHandlingTimeMs);
+ loadUrlParams.setVerbatimHeaders(headers);
+ return getTabCreator(isIncognito).createNewTab(
+ loadUrlParams,
fromLauncherShortcut ? TabLaunchType.FROM_EXTERNAL_APP
: TabLaunchType.FROM_LINK,
- intent,
- mIntentHandlingTimeMs);
+ null,
+ intent);
} else {
return getTabCreator(false).launchUrlFromExternalApp(url, referer, headers,
externalAppId, forceNewTab, intent, mIntentHandlingTimeMs);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698